Re: [net-next 06/15] net/mlx5e: Fail with messages when params are not valid for XSK
From: Jacob Keller <jacob.e.keller@intel.com>
Date: 2023-01-18 21:42:55
From: Jacob Keller <jacob.e.keller@intel.com>
Date: 2023-01-18 21:42:55
On 1/18/2023 10:35 AM, Saeed Mahameed wrote:
From: Adham Faris <redacted> Current XSK prerequisites validation implementation (setup.c/mlx5e_validate_xsk_param()) fails silently when xsk prerequisites are not fulfilled. Add error messages to the kernel log to help the user understand what went wrong when params are not valid for XSK. Signed-off-by: Adham Faris <redacted> Reviewed-by: Tariq Toukan <tariqt@nvidia.com> Signed-off-by: Saeed Mahameed <saeedm@nvidia.com>
Makes sense. I'm not familiar with the XSK configuration but I assume we don't have netlink_ext_ack or similar for error message reporting here. Reviewed-by: Jacob Keller <jacob.e.keller@intel.com>