Re: [net-next PATCH v12 4/4] net: dsa: mv88e6xxx: Add support for mv88e6393x family of Marvell
From: Marek Behún <kabel@kernel.org>
Date: 2021-01-05 12:16:25
Also in:
linux-devicetree, lkml, oe-kbuild-all
On Fri, 11 Dec 2020 22:51:01 +1000 Pavana Sharma [off-list ref] wrote:
+int mv88e6393x_serdes_irq_enable(struct mv88e6xxx_chip *chip, int port,
+ int lane, bool enable)
+{
+ u8 cmode = chip->ports[port].cmode;
+ int err = 0;
+
+ switch (cmode) {
+ case MV88E6XXX_PORT_STS_CMODE_SGMII:
+ case MV88E6XXX_PORT_STS_CMODE_1000BASEX:
+ case MV88E6XXX_PORT_STS_CMODE_2500BASEX:
+ case MV88E6XXX_PORT_STS_CMODE_5GBASER:
+ case MV88E6XXX_PORT_STS_CMODE_10GBASER:
+ err = mv88e6390_serdes_irq_enable_sgmii(chip, lane, enable);
+ }This is wrong. IRQ for 5gbase-r and 10gbase-r is enabled differently. Please look at how I did it in my proposal https://www.mail-archive.com/netdev@vger.kernel.org/msg347854.html Please look at the following functions in that patch: mv88e6393x_serdes_irq_enable_10g() mv88e6393x_serdes_irq_enable() mv88e6393x_serdes_irq_status_10g() irqreturn_t mv88e6393x_serdes_irq_status() and also at the constants added to serdes.h in that patch #define MV88E6393X_10G_INT_ENABLE 0x9000 #define MV88E6393X_10G_INT_LINK_CHANGE BIT(2) #define MV88E6393X_10G_INT_STATUS 0x9001