Thread (101 messages) flat view 101 messages, 8 authors, 2021-01-09

Re: [PATCH v11 3/4] net: dsa: mv88e6xxx: Change serdes lane parameter type from u8 type to int

From: Andrew Lunn <andrew@lunn.ch>
Date: 2020-12-09 23:24:58
Also in: linux-devicetree, lkml, oe-kbuild-all

On Wed, Dec 09, 2020 at 03:05:17PM +1000, Pavana Sharma wrote:
Returning 0 is no more an error case with MV88E6393 family
which has serdes lane numbers 0, 9 or 10.
So with this change .serdes_get_lane will return lane number
or -errno (-ENODEV or -EOPNOTSUPP).

Signed-off-by: Pavana Sharma <redacted>
I see here you did actually act on my comment. Thanks.

But i also said:
Other than that:

Reviewed-by: Andrew Lunn <andrew@lunn.ch>
Please add such tags to new versions of the patches. It then makes it
easier for everybody to know the review state of the patches, which
have been reviewed and deemed O.K, and which need more review.

     Thanks
	Andrew
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help