Re: [PATCH v10 3/4] net: dsa: mv88e6xxx: Change serdes lane parameter from u8 type to int
From: Andrew Lunn <andrew@lunn.ch>
Date: 2020-11-20 01:00:22
Also in:
linux-devicetree, lkml, oe-kbuild-all
quoted hunk ↗ jump to hunk
@@ -459,7 +459,7 @@ static int mv88e6xxx_port_set_cmode(struct mv88e6xxx_chip *chip, int port, chip->ports[port].cmode = cmode; lane = mv88e6xxx_serdes_get_lane(chip, port); - if (!lane) + if (lane < 0) return -ENODEV;
return lane
since lane is an errno.
Other than that:
Reviewed-by: Andrew Lunn <andrew@lunn.ch>
Andrew