Re: [PATCH v11 2/4] net: phy: Add 5GBASER interface mode
From: Andrew Lunn <andrew@lunn.ch>
Date: 2020-12-09 23:19:02
Also in:
linux-devicetree, lkml, oe-kbuild-all
On Wed, Dec 09, 2020 at 03:04:23PM +1000, Pavana Sharma wrote:
quoted hunk ↗ jump to hunk
Add 5GBASE-R phy interface mode Signed-off-by: Pavana Sharma <redacted> --- include/linux/phy.h | 5 +++++ 1 file changed, 5 insertions(+)diff --git a/include/linux/phy.h b/include/linux/phy.h index 56563e5e0dc7..8151e6ecf1b9 100644 --- a/include/linux/phy.h +++ b/include/linux/phy.h@@ -106,6 +106,7 @@ extern const int phy_10gbit_features_array[1]; * @PHY_INTERFACE_MODE_TRGMII: Turbo RGMII * @PHY_INTERFACE_MODE_1000BASEX: 1000 BaseX * @PHY_INTERFACE_MODE_2500BASEX: 2500 BaseX + * @PHY_INTERFACE_MODE_5GBASER: 5G BaseR * @PHY_INTERFACE_MODE_RXAUI: Reduced XAUI * @PHY_INTERFACE_MODE_XAUI: 10 Gigabit Attachment Unit Interface * @PHY_INTERFACE_MODE_10GBASER: 10G BaseR@@ -137,6 +138,8 @@ typedef enum { PHY_INTERFACE_MODE_TRGMII, PHY_INTERFACE_MODE_1000BASEX, PHY_INTERFACE_MODE_2500BASEX, + /* 5GBASE-R mode */ + PHY_INTERFACE_MODE_5GBASER, PHY_INTERFACE_MODE_RXAUI, PHY_INTERFACE_MODE_XAUI,
For v10 i said:
Again, what is the value of the comment? 10GBASE-R has a comment because it is different from the rest, XFI and SFI caused a of discussion, and it was used wrong. But there does not seem to be anything special for 5GBASE-R.
Please don't ignore comments. If you don't understand, please ask. If you think the comments are wrong, please explain why, so we can discuss it. Andrew