Re: [PATCH v4 1/3] Add support for mv88e6393x family of Marvell.

Hi Pavana,

Thank you for the patch! Perhaps something to improve:

[auto build test WARNING on linus/master]
[also build test WARNING on linux/master v5.10-rc1 next-20201027]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/0day-ci/linux/commits/Pavana-Sharma/Add-support-for-mv88e6393x-family-of-Marvell/20201026-140237
base:   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git 3650b228f83adda7e5ee532e2b90429c03f7b9ec
config: arm-randconfig-r013-20201026 (attached as .config)
compiler: clang version 12.0.0 (https://github.com/llvm/llvm-project f2c25c70791de95d2466e09b5b58fc37f6ccd7a4)
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # install arm cross compiling tool for clang build
        # apt-get install binutils-arm-linux-gnueabi
        # https://github.com/0day-ci/linux/commit/6bac8985349e1ceedb3d4e9bba18563fb15613c0
        git remote add linux-review https://github.com/0day-ci/linux
        git fetch --no-tags linux-review Pavana-Sharma/Add-support-for-mv88e6393x-family-of-Marvell/20201026-140237
        git checkout 6bac8985349e1ceedb3d4e9bba18563fb15613c0
        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross ARCH=arm 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <redacted>

All warnings (new ones prefixed by >>):

quoted

drivers/net/dsa/mv88e6xxx/port.c:29:5: warning: no previous prototype for function 'mv88e6xxx_port_wait_bit' [-Wmissing-prototypes]

   int mv88e6xxx_port_wait_bit(struct mv88e6xxx_chip *chip, int port, int reg,
       ^
   drivers/net/dsa/mv88e6xxx/port.c:29:1: note: declare 'static' if the function is not intended to be used outside of this translation unit
   int mv88e6xxx_port_wait_bit(struct mv88e6xxx_chip *chip, int port, int reg,
   ^
   static 
   drivers/net/dsa/mv88e6xxx/port.c:513:7: error: use of undeclared identifier 'PHY_INTERFACE_MODE_5GBASER'; did you mean 'PHY_INTERFACE_MODE_10GBASER'?
           case PHY_INTERFACE_MODE_5GBASER:
                ^~~~~~~~~~~~~~~~~~~~~~~~~~
                PHY_INTERFACE_MODE_10GBASER
   include/linux/phy.h:143:2: note: 'PHY_INTERFACE_MODE_10GBASER' declared here
           PHY_INTERFACE_MODE_10GBASER,
           ^
   drivers/net/dsa/mv88e6xxx/port.c:516:7: error: duplicate case value 'PHY_INTERFACE_MODE_10GBASER'
           case PHY_INTERFACE_MODE_10GBASER:
                ^
   drivers/net/dsa/mv88e6xxx/port.c:513:7: note: previous case defined here
           case PHY_INTERFACE_MODE_5GBASER:
                ^
   1 warning and 2 errors generated.

vim +/mv88e6xxx_port_wait_bit +29 drivers/net/dsa/mv88e6xxx/port.c

    28	
  > 29	int mv88e6xxx_port_wait_bit(struct mv88e6xxx_chip *chip, int port, int reg,
    30			int bit, int val)
    31	{
    32		int addr = chip->info->port_base_addr + port;
    33		return mv88e6xxx_wait_bit(chip, addr, reg, bit, val);
    34	}
    35	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org