Thread (65 messages) 65 messages, 9 authors, 2018-09-25

Re: [PATCH net-next v5 02/20] zinc: introduce minimal cryptography library

From: "Jason A. Donenfeld" <Jason@zx2c4.com>
Date: 2018-09-21 04:16:05
Also in: linux-crypto, lkml

Hi Andy,

On Fri, Sep 21, 2018 at 5:23 AM Andy Lutomirski [off-list ref] wrote:
At the risk on suggesting something awful: on x86_64, since we turn preemption off for simd, it wouldn’t be *completely* insane to do the crypto on the irq stack. It would look like:

kernel_fpu_call(func, arg);

And this helper would disable preemption, enable FPU, switch to the irq stack, call func(arg), disable FPU, enable preemption, and return. And we can have large IRQ stacks.

I refuse to touch this with a ten-foot pole until the lazy FPU restore patches land.
Haha. That's fun, and maybe we'll do that at some point, but I have
some other reasons too for being on a workqueue now.
All that being said, why are these frames so large?  It sounds like something may be spilling that ought not to.
They're not. Well, they're not anymore. I had a silly thing before
like "u8 buffer[1 << 12]" in some debugging code, which is what
prompted the ccflag-y addition. I cleaned up the mistakes like that
and frames are now reasonable everywhere. Non-issue.

Jason
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help