Re: [PATCH net-next v5 12/20] zinc: BLAKE2s generic C implementation and selftest

From
Jason A. Donenfeld <Jason@zx2c4.com>
Date
2018-09-19 00:46:03
Also in
linux-crypto, lkml
Reply to
Eric Biggers, 2018-09-19
Hey Eric,

On Wed, Sep 19, 2018 at 2:41 AM Eric Biggers [off-list ref] wrote:
This buffer is 4 times too long.
Nice catch.
Or how about something much simpler:

static inline void blake2s_final(struct blake2s_state *state, u8 *out,
                                 const size_t outlen)
{
#ifdef DEBUG
        BUG_ON(!out || !outlen || outlen > BLAKE2S_OUTBYTES);
#endif
        __blake2s_final(state);

        cpu_to_le32_array(state->h, ARRAY_SIZE(state->h));
        memcpy(out, state->h, outlen);

        memzero_explicit(state, sizeof(*state));
}
Oh, that's excellent, thanks. Much better than prior. I'll do exactly that.

Jason
Thread (65 messages) 65 messages, 9 authors, last reply 2018-09-25
Keyboard shortcuts
hback out one level
jnext message in thread / next series-diff position
kprevious message in thread / previous series-diff position
ldrill in
Escclose help / fold thread tree
?toggle this help