Re: [PATCH net-next v5 07/20] zinc: Poly1305 generic C implementations and selftest

From
Jason A. Donenfeld <Jason@zx2c4.com>
Date
2018-09-19 01:42:02
Also in
linux-crypto, lkml
Reply to
Jason A. Donenfeld, 2018-09-19
On Wed, Sep 19, 2018 at 3:39 AM Jason A. Donenfeld [off-list ref] wrote:
quoted
quoted
+     const size_t num = ctx->num % POLY1305_BLOCK_SIZE;
0 <= ctx->num < POLY1305_BLOCK_SIZE, so no need to mod by POLY1305_BLOCK_SIZE.
quoted
+     size_t num = ctx->num % POLY1305_BLOCK_SIZE;
Same here.
I know, but I was having a hard time convincing gcc-8 of that
invariant, and it was warning me. Perhaps this is something they
fixed, though, between 8.1 and 8.2 though. I'll check back and adjust
accordingly.
This was changed here:
https://git.zx2c4.com/WireGuard/commit/?id=37f114a73ba37219b00a66f0a51219a696599745

I can't reproduce with 8.2 anymore, so perhaps I should remove it now.
Unless you'd like to avoid a warning on old compilers. Since there's
no difference in speed, probably we should avoid the 8.1 warning and
leave it be?
Thread (65 messages) 65 messages, 9 authors, last reply 2018-09-25
Keyboard shortcuts
hback out one level
jnext message in thread / next series-diff position
kprevious message in thread / previous series-diff position
ldrill in
Escclose help / fold thread tree
?toggle this help