Re: [PATCH net-next v5 20/20] net: WireGuard secure network tunnel

From
Andrew Lunn <andrew@lunn.ch>
Date
2018-09-19 12:39:00
Also in
linux-crypto, lkml
Reply to
Jason A. Donenfeld, 2018-09-19
On Wed, Sep 19, 2018 at 04:04:01AM +0200, Jason A. Donenfeld wrote:
Hi Andrew,

On Wed, Sep 19, 2018 at 1:34 AM Andrew Lunn [off-list ref] wrote:
quoted
I see this BUG_ON() is still here. It really needs to be removed. It
does not look like you need to crash the kernel here. Can you add in a
test of len >= 128, do a WARN and then return. I think you then leak
some memory, but i would much prefer that to a crashed machine.
Sure, I'll change it to that.
Great, thanks. I noticed there is at least one more BUG()
statements. It would be good to remove them all. BUG() should only be
used when something bad has already happened and we want to minimise
the damage by killing the machine immediately.

    Andrew
Thread (65 messages) 65 messages, 9 authors, last reply 2018-09-25
Keyboard shortcuts
hback out one level
jnext message in thread / next series-diff position
kprevious message in thread / previous series-diff position
ldrill in
Escclose help / fold thread tree
?toggle this help