Re: [PATCH net-next v5 02/20] zinc: introduce minimal cryptography library
From: Ard Biesheuvel <hidden>
Date: 2018-09-20 15:42:00
Also in:
linux-crypto, lkml
(+ Arnd, Eric) On 18 September 2018 at 09:16, Jason A. Donenfeld [off-list ref] wrote: ...
quoted hunk ↗ jump to hunk
diff --git a/lib/zinc/Makefile b/lib/zinc/Makefile new file mode 100644 index 000000000000..83dfd63988c0 --- /dev/null +++ b/lib/zinc/Makefile@@ -0,0 +1,4 @@
Apologies for not spotting these before:
+ccflags-y := -O3
-O3 optimization has been problematic in the past, at least on x86 but I think on other architectures as well. Please stick with -O2.
+ccflags-y += -Wframe-larger-than=$(if (CONFIG_KASAN),16384,8192)
There is no way we can support code in the kernel with that kind of stack space requirements. I will let Arnd comment on what we typically allow, since he deals with such issues on a regular basis.
+ccflags-y += -D'pr_fmt(fmt)="zinc: " fmt' +ccflags-$(CONFIG_ZINC_DEBUG) += -DDEBUG -- 2.19.0