Thread (161 messages) 161 messages, 13 authors, 2013-11-21

Re: gso: Handle new frag_list of frags GRO packets

From: Herbert Xu <herbert@gondor.apana.org.au>
Date: 2013-11-13 01:29:33

On Tue, Nov 12, 2013 at 05:13:43PM -0800, Eric Dumazet wrote:
Note this pskb_trim() will reallocate/copy nskb head completely, since
nskb is a clone. (And increment page counts of frags, then eventually
decrement them)

I tested this patch one 'router', and it seems fine, although we consume
~90% more cpu doing the skb_segment() than not doing it.
I presume this is on a NIC that produces completely linear packets?
I wonder what happens if we don't convert head_frag to frags and just
use frag_lists like we used to?

Thanks,
-- 
Email: Herbert Xu [off-list ref]
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help