Re: gso: Attempt to handle mega-GRO packets
From: Herbert Xu <herbert@gondor.apana.org.au>
Date: 2013-11-06 08:04:34
From: Herbert Xu <herbert@gondor.apana.org.au>
Date: 2013-11-06 08:04:34
On Tue, Nov 05, 2013 at 09:20:22PM -0800, Eric Dumazet wrote:
On Wed, 2013-11-06 at 12:28 +0800, Herbert Xu wrote:quoted
On Tue, Nov 05, 2013 at 08:23:05PM -0800, Eric Dumazet wrote:quoted
Nope, I already mentioned this : Please take a look at 2613af0ed18a11d5c566a81f9a6510b73180660a ("virtio_net: migrate mergeable rx buffers to page frag allocators")This patch should simply be reverted. You guys steam-rolled over the virtio_net people's concerns that this seriously impacts virt performance.Have you followed netdev traffic lately ? virtio_net performance is better than before, and we did no revert, thank you.
The last email I saw from Michael Tsirkin he still wasn't happy that your patch does not degrade virt performance. Where is the reply to that? Cheers, -- Email: Herbert Xu [off-list ref] Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt