Re: gso: Attempt to handle mega-GRO packets
From: Joe Perches <joe@perches.com>
Date: 2013-11-06 17:25:49
On Wed, 2013-11-06 at 22:39 +0800, Herbert Xu wrote:
On Wed, Nov 06, 2013 at 09:30:45PM +0800, Herbert Xu wrote:quoted
In order to handle malicious GSO packets that is now possible with the use of frag_list in virtio_net, we need to remove the BUG_ONs.
[]
Still totally untested but at least this has a chance of handling the new virtio_net.
trivial: please add "\n" to each net_warn_ratelimited format termination.
quoted hunk ↗ jump to hunk
diff --git a/net/core/skbuff.c b/net/core/skbuff.c
[]
quoted hunk ↗ jump to hunk
@@ -2861,15 +2853,62 @@ struct sk_buff *skb_segment(struct sk_buff *skb, netdev_features_t features)
[]
+ if (skb_has_frag_list(nskb)) {
+ net_warn_ratelimited(
+ "skb_segment: "
+ "nested frag_list detected");"nested frag_list detected\n"); etc... It might be nicer to coalesce the format fragments too.