Thread (161 messages) 161 messages, 13 authors, 2013-11-21

Re: Bug in skb_segment: fskb->len != len

From: Herbert Xu <herbert@gondor.apana.org.au>
Date: 2013-10-30 04:06:46

On Tue, Oct 29, 2013 at 09:03:05PM -0700, Eric Dumazet wrote:
On Wed, 2013-10-30 at 09:50 +0800, Herbert Xu wrote:
quoted
Indeed I missed this.  Which commit introduced this change?
This was mentioned in the changelog :

<quote>

Christoph Paasch and Jerry Chu reported crashes in skb_segment() caused
by commit 8a29111c7ca6 ("net: gro: allow to build full sized skb")

</quote>
Thanks.

In that case we should be able to segment these full-sized skbs
without linearising.  What we should do is iterate through
each frag_list entry and apply the usual GSO code to them.

Cheers,
-- 
Email: Herbert Xu [off-list ref]
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help