Thread (161 messages) 161 messages, 13 authors, 2013-11-21

Re: [PATCH v4 net-next] net: introduce dev_set_forwarding()

From: Herbert Xu <herbert@gondor.apana.org.au>
Date: 2013-11-08 05:21:27

On Thu, Nov 07, 2013 at 09:08:49PM -0800, Eric Dumazet wrote:
On Fri, 2013-11-08 at 12:43 +0800, Herbert Xu wrote:
quoted
Easy.  You don't physically segment the packet until it's
transmitted.  But logically you treat each GRO/GSO packet as if it
had already been segmented.
OK, please submit some patches, because I must be blind.
Honestly it doesn't even matter.  If it's really so bad for your
qdisc, you should just call skb_segment in your qdisc directly.

My point is that even if you did that GRO with your frag_list
patch should still be a win because the stack prior to the qdisc
gets run once instead of two or three times.

Cheers,
-- 
Email: Herbert Xu [off-list ref]
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help