RE: [PATCH 3/4] char/tpm: Improve a size determination in nine functions
From: <hidden>
Date: 2017-10-19 16:58:31
Also in:
kernel-janitors, linux-integrity, lkml
On Tue, Oct 17, 2017 at 11:50:05AM +0000, Alexander.Steffen@infineon.com wrote:quoted
quoted
quoted
Replace the specification of data structures by pointer dereference=
s
quoted
quoted
quoted
as the parameter for the operator "sizeof" to make the correspondin=
g
quoted
quoted
quoted
size determination a bit safer according to the Linux coding style convention.This patch does one style in favor of the other.I actually prefer that style, so I'd welcome this change :)quoted
At the end it's Jarkko's call, though I would NAK this as I think som=
e
quoted
quoted
one already told this to you for some other similar patch(es). I even would suggest to stop doing this noisy stuff, which keeps peop=
le
quoted
quoted
busy for nothing.Cleaning up old code is also worth something, even if does not change one bit in the assembly output in the end... Alexander=20 Quite insignificant clean up it is that does more harm that gives any benefit as any new change adds debt to backporting. =20 Anyway, this has been a useful patch set for me in the sense that I have clearer picture now on discarding/accepting commits.
Indeed. I have now a better understanding for why some code looks as ugly a= s it does.
One line minor clean up will be from now on automatic NAK unless it causes a compiler warning or some other visible side-effect.
Not a nice policy, but at least a policy. I have deleted the tasks that I h= ad still planned for other cleanup activities. Alexander