Re: [PATCH 3/4] char/tpm: Improve a size determination in nine functions
From: Jarkko Sakkinen <hidden>
Date: 2017-10-18 14:48:23
Also in:
kernel-janitors, linux-integrity, lkml
From: Jarkko Sakkinen <hidden>
Date: 2017-10-18 14:48:23
Also in:
kernel-janitors, linux-integrity, lkml
On Tue, Oct 17, 2017 at 11:50:05AM +0000, Alexander.Steffen@infineon.com wrote:
quoted
quoted
Replace the specification of data structures by pointer dereferences as the parameter for the operator "sizeof" to make the corresponding size determination a bit safer according to the Linux coding style convention.This patch does one style in favor of the other.I actually prefer that style, so I'd welcome this change :)quoted
At the end it's Jarkko's call, though I would NAK this as I think some one already told this to you for some other similar patch(es). I even would suggest to stop doing this noisy stuff, which keeps people busy for nothing.Cleaning up old code is also worth something, even if does not change one bit in the assembly output in the end... Alexander
Quite insignificant clean up it is that does more harm that gives any benefit as any new change adds debt to backporting. Anyway, this has been a useful patch set for me in the sense that I have clearer picture now on discarding/accepting commits. One line minor clean up will be from now on automatic NAK unless it causes a compiler warning or some other visible side-effect. /Jarkko