Thread (88 messages) 88 messages, 13 authors, 2017-10-23

Re: [PATCH 0/4] char-TPM: Adjustments for ten function implementations

From: Jarkko Sakkinen <hidden>
Date: 2017-10-18 15:08:08
Also in: kernel-janitors, linux-integrity, lkml

On Tue, Oct 17, 2017 at 12:44:34PM +0300, Dan Carpenter wrote:
On Tue, Oct 17, 2017 at 10:56:42AM +0200, Julia Lawall wrote:
quoted

On Tue, 17 Oct 2017, Dan Carpenter wrote:
quoted
On Mon, Oct 16, 2017 at 09:35:12PM +0300, Jarkko Sakkinen wrote:
quoted
A minor complaint: all commits are missing "Fixes:" tag.
Fixes is only for bug fixes.  These don't fix any bugs.
0-day seems to put Fixes for everything.  Should they be removed when the
old code is undesirable but doesn't actually cause a crash, eg out of date
API.
Yeah, I feel like Fixes tags don't belong for API updates and cleanups.

regards,
dan carpenter
So breaking a rule documented in the style guide is not a bug? :-)

/Jarkko
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help