On Tue, Oct 17, 2017 at 04:02:05PM +0300, Andy Shevchenko wrote:

On Tue, 2017-10-17 at 08:52 -0400, Mimi Zohar wrote:

quoted

On Tue, 2017-10-17 at 11:50 +0000, Alexander.Steffen@infineon.com
wrote:

quoted

quoted

quoted

Replace the specification of data structures by pointer
dereferences
as the parameter for the operator "sizeof" to make the
corresponding
size
determination a bit safer according to the Linux coding style
convention.

This patch does one style in favor of the other.

I actually prefer that style, so I'd welcome this change :)

Style changes should be reviewed and documented, like any other code
change, and added to Documentation/process/coding-style.rst or an
equivalent file.

+1.

quoted

quoted

quoted

At the end it's Jarkko's call, though I would NAK this as I think
some
one already told this to you for some other similar patch(es).


I even would suggest to stop doing this noisy stuff, which keeps
people
busy for nothing.

Cleaning up old code is also worth something, even if does not
change one bit in the assembly output in the end...

Wow, you're opening the door really wide for all sorts of trivial
changes!  Hope you have the time and inclination to review and comment
on all of them.  I certainly don't.

Moreover and not so obvious is an open door for making back port of
*real* fixes much harder!

Yes. This is really the key observation:

  A commit must have value above the cost of fixing a merge conflict.

/Jarkko