Thread (27 messages) flat view 27 messages, 5 authors, 2012-08-01

RE: [PATCH V3 2/5] powerpc/fsl-pci: Determine primary bus by looking for ISA node

From: Jia Hongtao-B38951 <hidden>
Date: 2012-07-27 02:57:10

-----Original Message-----
From: Kumar Gala [mailto:galak@kernel.crashing.org]
Sent: Friday, July 27, 2012 2:22 AM
To: Jia Hongtao-B38951
Cc: linuxppc-dev@lists.ozlabs.org; Wood Scott-B07421; Li Yang-R58472
Subject: Re: [PATCH V3 2/5] powerpc/fsl-pci: Determine primary bus by
looking for ISA node
=20
=20
On Jul 26, 2012, at 7:30 AM, Jia Hongtao wrote:
=20
quoted
PCI host bridge is primary bus if it contains an ISA node. But not all
boards
quoted
fit this rule. Device tree should be updated for all these boards.
=20
I don't really seen any reason for this patch.  We can just use the code
as Scott wrote it that sets fsl_pci_primary based on search for the isa
node.
=20

I change the way of searching ISA node just because the platform driver
mechanism. Probe function of this driver will be called for each PCI
controller which means more than once. I think the Scott's way is not
perfectly match this situation. Anyway I will find a better way to solve
this by refactoring the Scott's method or using my own way.

Thanks.
-Hongtao.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help