Re: [PATCH 00/23] per device dirty throttling -v8

* Alan Cox [off-list ref] wrote:

quoted

also add the CONFIG_DEFAULT_RELATIME kernel option, which makes 
"norelatime" the default for all mounts without an extra kernel boot 
option.

Should be a mount option.

it is already a mount option too.

quoted

+	relatime        [FS] default to enabled relatime updates on all
+			filesystems.
+
+	relatime=       [FS] default to enabled/disabled relatime updates on
+			all filesystems.
+

Double patch

no - it was not a double patch, i made all the common variants valid 
boot options: "relatime", "relatime=0/1", "norelatime" and 
"norelatime=0/1". Anyway, this is mooth, in the latest (v2) version 
there's only a single boot parameter.

quoted

+config DEFAULT_RELATIME
+	bool "Mount all filesystems with relatime by default"
+	default y

Changes behaviour so probably should default n. Better yet it should 
be the mount option so its flexible and strongly encouraged for 
vendors.

relatime is a mount option already. And distros can disable it if they 
want. (they are conscious about their kernel config selections anyway.)

quoted

+0
+#endif
+;

This ifdef mess would go away for a mount option

i fixed that in v2.

	Ingo

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>