Re: [PATCH v2 19/23] arm64: dts: mt8192: Add i2c aliases
From: Chen-Yu Tsai <wenst@chromium.org>
Date: 2022-02-21 04:50:31
Also in:
linux-devicetree, linux-mediatek, lkml
Hi, On Fri, Feb 18, 2022 at 5:16 PM Allen-KH Cheng [off-list ref] wrote:
quoted hunk ↗ jump to hunk
Add i2c aliases for mt8192 SoC Signed-off-by: Allen-KH Cheng <redacted> --- arch/arm64/boot/dts/mediatek/mt8192.dtsi | 13 +++++++++++++ 1 file changed, 13 insertions(+)diff --git a/arch/arm64/boot/dts/mediatek/mt8192.dtsi b/arch/arm64/boot/dts/mediatek/mt8192.dtsi index 55bcbf72a366..e3314cdc7c1a 100644 --- a/arch/arm64/boot/dts/mediatek/mt8192.dtsi +++ b/arch/arm64/boot/dts/mediatek/mt8192.dtsi@@ -21,6 +21,19 @@ #address-cells = <2>; #size-cells = <2>; + aliases { + i2c0 = &i2c0; + i2c1 = &i2c1; + i2c2 = &i2c2; + i2c3 = &i2c3; + i2c4 = &i2c4; + i2c5 = &i2c5; + i2c6 = &i2c6; + i2c7 = &i2c7; + i2c8 = &i2c8; + i2c9 = &i2c9;
AFAIK, maintainers have suggested against [1] having aliases in the .dtsi. If the numbering isn't an issue, I suggest just dropping it altogether. If it is, then the aliases should be added at the board level, and only for the interfaces that are actually enabled. ChenYu [1] https://lore.kernel.org/linux-rockchip/CAK8P3a25iYksubCnQb1-e5yj=crEsK37RB9Hn4ZGZMwcVVrG7g@mail.gmail.com/ (local)
+ };
+
clk26m: oscillator0 {
compatible = "fixed-clock";
#clock-cells = <0>;
--
2.18.0_______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel