Thread (58 messages) flat view 58 messages, 5 authors, 2012-02-23

[PATCH v2 02/19] ARM: at91/at91x40: remove use of at91_sys_read/write

From: Ryan Mallon <hidden>
Date: 2012-02-22 22:22:45
Also in: lkml

On 22/02/12 20:39, Nicolas Ferre wrote:
quoted hunk ↗ jump to hunk
From: Jean-Christophe PLAGNIOL-VILLARD <redacted>

Signed-off-by: Jean-Christophe PLAGNIOL-VILLARD <redacted>
Acked-by: Nicolas Ferre <redacted>
---
 arch/arm/mach-at91/at91x40.c              |    2 +-
 arch/arm/mach-at91/at91x40_time.c         |   28 +++++++++++++++++-----------
 arch/arm/mach-at91/include/mach/at91x40.h |   18 +++++++++---------
 3 files changed, 27 insertions(+), 21 deletions(-)
diff --git a/arch/arm/mach-at91/at91x40.c b/arch/arm/mach-at91/at91x40.c
index 0154b7f..5400a1d 100644
--- a/arch/arm/mach-at91/at91x40.c
+++ b/arch/arm/mach-at91/at91x40.c
@@ -44,7 +44,7 @@ static void at91x40_idle(void)
 	 * Disable the processor clock.  The processor will be automatically
 	 * re-enabled by an interrupt or by a reset.
 	 */
-	at91_sys_write(AT91_PS_CR, AT91_PS_CR_CPU);
+	__raw_writel(AT91_PS_CR_CPU, AT91_PS_CR);

This doesn't seem to be equivalent, at91_sys_write does:

  void __iomem *addr = (void __iomem *)AT91_VA_BASE_SYS;
  __raw_writel(value, addr + reg_offset);

and this patch doesn't redefine AT91_PS_CR. Was it broken before this
patch? What am I missing?

~Ryan
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help