Thread (58 messages) flat view 58 messages, 5 authors, 2012-02-23

[PATCH v2 12/19] ARM: at91/rtc-at91sam9: each SoC can select the RTT device to use

From: Jean-Christophe PLAGNIOL-VILLARD <hidden>
Date: 2012-02-22 18:18:08
Also in: lkml

On 17:25 Wed 22 Feb     , Arnd Bergmann wrote:
On Wednesday 22 February 2012, Jean-Christophe PLAGNIOL-VILLARD wrote:
quoted
quoted
But if you change the rtc driver to always bind to the existing
"at91_rtt" platform_device and fail the probe() function for the
case that you are on at91sam9263 probing the non-RTC device,
you should get the exact same result without any extra code
in the per-soc files.
agreed but as on at91sam9263 you have 2 RTTs so you can have 2 drivers at the
same time that use the RTT. So we can not do this except if we set the second
RTT to an other device name.
Let me rephrase what I meant then:

The first driver should in its probe function do:

	if (pdev->id != CONFIG_RTC_DRV_AT91SAM9_RTT)
		return -ENODEV;

while the other driver does

	if (pdev->id == CONFIG_RTC_DRV_AT91SAM9_RTT)
		return -ENODEV;

This way, each driver binds to one device but not the other.
It should even work with an unmodified second driver, as long
as you guarantee that it's loaded after the first one.

Any reason why this won't work?
just one other issue I need to pass the GPBR ressource to the RTC driver only

Best Regards,
J.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help