[PATCH v2 02/19] ARM: at91/at91x40: remove use of at91_sys_read/write
From: arnd@arndb.de (Arnd Bergmann)
Date: 2012-02-22 14:39:13
Also in:
lkml
Hi Nicolas and Jean-Christophe, On Wednesday 22 February 2012, Nicolas Ferre wrote:
quoted hunk ↗ jump to hunk
--- a/arch/arm/mach-at91/at91x40.c +++ b/arch/arm/mach-at91/at91x40.c@@ -44,7 +44,7 @@ static void at91x40_idle(void) * Disable the processor clock. The processor will be automatically * re-enabled by an interrupt or by a reset. */ - at91_sys_write(AT91_PS_CR, AT91_PS_CR_CPU); + __raw_writel(AT91_PS_CR_CPU, AT91_PS_CR); cpu_do_idle(); }
How about making this writel_relaxed in the process? I would like to see the use of __raw_*() get reduced in code that gets touched. In most cases writel_relaxed/readl_relaxed is the correct accessor function instead. Arnd