Thread (46 messages) flat view 46 messages, 5 authors, 2016-06-15

Re: [PATCH v2 1/2] Introduce config variable "diff.primer"

From: Junio C Hamano <hidden>
Date: 2016-06-15 22:46:07

Possibly related (same subject, not in this thread)

Jeff King [off-list ref] writes:
Right, I am calling into question whether we want "--primer" at all.
That is, if you think of it as just "prepend these command line options"
we can get the same thing with something like:

  git diff-tree `git config diff.primer` $other_options

if the caller wants to be totally promiscuous, and

  git diff-tree `git config diff.primer | filter_options` $other_options

if it wants to be paranoid (and obviously in tcl the code would be
different, but I think you can see the point).
I agree with this 100%.

Also, I think we should explain the semantics of diff.primer to new people
like that.  "The diff Porcelain command acts as if whatever you have in
diff.primer are prepended on your command line".

Which means that we do not have to touch the plumbing at all.  That allows
me sleep much better at night.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help