Thread (46 messages) flat view 46 messages, 5 authors, 2016-06-15

Re: [PATCH] Add the diff option --no-defaults

From: Johannes Schindelin <hidden>
Date: 2016-06-15 22:46:37

Hi.

On Sat, 18 Apr 2009, Keith Cascio wrote:
On Sat, 18 Apr 2009, Johannes Schindelin wrote:
quoted
And I still do not like the intrusiveness of your patch.  The last 
time we did something like that with options (some 
parseoptifications), we had a lot of fallout as a consequence.
[...]

Peff expressed some specific concerns [...]
My concerns were also very specific: your patches are way too large.  
There is a rule of thumb that the likelihood of a bug is the square of the 
number of changed lines, I am sure you heard that before.
[...] your patch adds at least ten lines outside of diff.h/diff.c.
That is _such_ a red herring.

Ciao,
Dscho
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help