RE: [PATCH net-next 11/13] ravb: Factorise ravb_dmac_init function

Hi Sergei,

Thanks for the feedback.

Subject: Re: [PATCH net-next 11/13] ravb: Factorise ravb_dmac_init
function

On 8/25/21 10:01 AM, Biju Das wrote:

quoted

The DMAC IP on the R-Car AVB module has different initialization
parameters for RCR, TGC, TCCR, RIC0, RIC2, and TIC compared to DMAC IP
on the RZ/G2L Gigabit Ethernet module. Factorise the ravb_dmac_init
function to support the later SoC.

   Couldn't we resolve these differencies like the sh_eth driver does, by
adding the register values into the *struct* ravb_hw_info?

I will evaluate your proposal in terms of code size and data size
And with the current code and share the details in next RFC patchset
for supporting RZ/G2L with dmac_init function.
Based on the RFC discussion, we can conclude it.

Currently by looking at your proposal, I am seeing duplication of
Data in R-Car Gen3 and R-Car Gen2.

If statement for adding RIC3 register for RZ/G2L, which involves
Exposing another hwinfo bit.

Regards,
Biju

quoted

Signed-off-by: Biju Das <biju.das.jz@bp.renesas.com>
Reviewed-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>

[...]

MBR, Sergey