RE: [PATCH net-next 08/13] ravb: Factorise ravb_rx function

Hi Sergei,

Subject: Re: [PATCH net-next 08/13] ravb: Factorise ravb_rx function

On 8/25/21 10:01 AM, Biju Das wrote:

quoted

R-Car uses an extended descriptor in RX whereas, RZ/G2L uses normal
descriptor in RX. Factorise the ravb_rx function to support the later
SoC.

Signed-off-by: Biju Das <biju.das.jz@bp.renesas.com>
Reviewed-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>

[...]

quoted

diff --git a/drivers/net/ethernet/renesas/ravb_main.c

b/drivers/net/ethernet/renesas/ravb_main.c
index 148c974499b4..1cace5324261 100644

--- a/drivers/net/ethernet/renesas/ravb_main.c
+++ b/drivers/net/ethernet/renesas/ravb_main.c

@@ -562,8 +562,7 @@ static void ravb_rx_csum(struct sk_buff *skb)
 	skb_trim(skb, skb->len - sizeof(__sum16));  }

-/* Packet receive function for Ethernet AVB */ -static bool

ravb_rx(struct net_device *ndev, int *quota, int q)
+static bool ravb_rcar_rx(struct net_device *ndev, int *quota, int q)

   Mhm, isn't this too large a function to duplicate it all for RZ-G2?

For your reference, it is a large change. See [1].
[1] https://patchwork.kernel.org/project/linux-renesas-soc/patch/20210722141351.13668-18-biju.das.jz@bp.renesas.com/

Currently I am working on the name change and next RFC patchset for started adding
Initial support for RZ/G2. I am expecting your valuable suggestion on that granular
RFC Patch for RZ/G2(ravb_rx) function.

Regards,
Biju

[...]

MBR, Sergey