RE: [PATCH net-next 04/13] ravb: Add ptp_cfg_active to struct ravb_hw_info

Hi Sergei,

Thanks for the feedback.

Subject: Re: [PATCH net-next 04/13] ravb: Add ptp_cfg_active to struct
ravb_hw_info

On 27.08.2021 9:36, Biju Das wrote:

[...]

quoted

quoted

quoted

quoted

quoted

quoted

quoted

quoted

Do you agree GAC register(gPTP active in Config) bit in
AVB-DMAC

mode register(CCC) present only in R-Car Gen3?

quoted

quoted

quoted

    Yes.
    But you feature naming is totally misguiding, nevertheless...

It can still be changed.

     Thank goodness, yea!

We have to live with the first version of this in the git history,
but we can add more patches fixing up whatever is broken in the
unreviewed code which got merged.

quoted

quoted

Just suggest a new name.

     I'd prolly go with 'gptp' for the gPTP support and 'ccc_gac'
for the gPTP working also in CONFIG mode (CCC.GAC controls this

feature).

quoted

quoted

quoted

quoted

Biju, please could you work on a couple of patches to change the

names.

quoted

quoted

quoted

Yes. Will work on the patches to change the names as suggested.

    TIA!
    After some more thinking, 'no_gptp' seems to suit better for the
1st case Might need to invert the checks tho...

OK, Will do with invert checks.

So just to conclude,

'no_gptp' and 'ccc_gac' are the suggested names changes for the
previous patch and current patch.

     Your patches have been merged already. Might try to encompass all
gPTP features with one patch (just a thought)...

OK, in that case it will be taken care in next RFC patch set.

Regards,
Biju