Re: [PATCH net-next 06/18] ravb: Factorise ptp feature

On Mon, Jul 26, 2021 at 09:01:29AM +0000, Biju Das wrote:

Hi Sergei,

Thanks for the feedback.

quoted

Subject: Re: [PATCH net-next 06/18] ravb: Factorise ptp feature

HEllo!

On 7/22/21 5:13 PM, Biju Das wrote:

quoted

Gptp is active in CONFIG mode for R-Car Gen3, where as it is not

   It's gPTP, the manuals say. :-)

Ok.

quoted

quoted

active in CONFIG mode for R-Car Gen2. Add feature bits to handle both
cases.

   I have no idea why this single diff requires 2 fetaure bits....

Basically this is a HW feature.

1) for R-Car Gen3, gPTP is active in config mode (R-Car Gen3)
2) for R-Car Gen2, gPTP is not active in config mode (R-Car Gen2)
3) RZ/G2L does not support ptp feature.

This is useful information to put in he commit message. The commit
message should answer the question "Why is this change being made?",
since what is being changed should be obvious from the patch.

      Andrew