RE: [PATCH net-next 00/18] Add Gigabit Ethernet driver support

Hi Sergei,

Thanks for the feedback.

Subject: Re: [PATCH net-next 00/18] Add Gigabit Ethernet driver support

On 7/22/21 5:13 PM, Biju Das wrote:

quoted

The DMAC and EMAC blocks of Gigabit Ethernet IP is almost similar to

Ethernet AVB.

quoted

The Gigabit Etherner IP consists of Ethernet controller (E-MAC),

Internal TCP/IP Offload Engine (TOE) and Dedicated Direct memory access
controller (DMAC).

quoted

With few changes in driver, we can support Gigabit ethernet driver as

well.

quoted

This patch series is aims to support the same

RFC->V1
  * Incorporated feedback from Andrew, Sergei, Geert and Prabhakar
  *
https://jpn01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fpatc
hwork.kernel.org%2Fproject%2Flinux-renesas-soc%2Flist%2F%3Fseries%3D51
5525&data=04%7C01%7Cbiju.das.jz%40bp.renesas.com%7Cb01d51eb4442476
149d608d94d52d7c9%7C53d82571da1947e49cb4625a166a4a2a%7C0%7C0%7C6376258
40484693261%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMz
IiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&sdata=M6biLbregS1y2R%2BMNb
b5PRRvgQxympZfHZkbuH0ZrXI%3D&reserved=0

Biju Das (18):
  dt-bindings: net: renesas,etheravb: Document Gigabit Ethernet IP
  drivers: clk: renesas: rzg2l-cpg: Add support to handle MUX clocks
  drivers: clk: renesas: r9a07g044-cpg: Add ethernet clock sources
  drivers: clk: renesas: r9a07g044-cpg: Add GbEthernet clock/reset

   It's not a good idea to have the patch to the defferent subsystems
lumped all together in a single series...

quoted

  ravb: Replace chip type with a structure for driver data

   I was expecting some real changes on how the gen2/3 diff. features in
this patch, but I only saw new info having no real changes where they were
needed and having the changes that did not need to be converted yet...
   Anwyay, I have stopped here for today.

This patch is a preparation patch. On the subsequent patches[1] [2] and [3] you will see the real hw changes wr.to gen2/gen3. Feature bit is not added in this patch, but on the subsequent patches. I believe you haven't reviewed that patches yet.

PTP feature and the diff between gen2/gen3
------------------------------------------
[1] https://patchwork.kernel.org/project/linux-renesas-soc/patch/20210722141351.13668-7-biju.das.jz@bp.renesas.com/


Features specific to R-Car Gen3
--------------------------------
[2] https://patchwork.kernel.org/project/linux-renesas-soc/patch/20210722141351.13668-8-biju.das.jz@bp.renesas.com/


R-Car common features
---------------------

[3] https://patchwork.kernel.org/project/linux-renesas-soc/patch/20210722141351.13668-9-biju.das.jz@bp.renesas.com/

There is a review comment for making smaller changes. 
what do you recommend after going through [1],[2] and [3]. 
Please let us know.

Regards,
Biju

quoted

  ravb: Factorise ptp feature
  ravb: Add features specific to R-Car Gen3
  ravb: Add R-Car common features
  ravb: Factorise ravb_ring_free function
  ravb: Factorise ravb_ring_format function
  ravb: Factorise ravb_ring_init function
  ravb: Factorise {emac,dmac} init function
  ravb: Factorise ravb_rx function
  ravb: Factorise ravb_adjust_link function
  ravb: Factorise ravb_set_features
  ravb: Add reset support
  ravb: Add GbEthernet driver support
  arm64: dts: renesas: r9a07g044: Add GbEther nodes

[...]

MBR, Sergei