Thread (42 messages) 42 messages, 6 authors, 2021-08-20

Re: [PATCH net-next 00/18] Add Gigabit Ethernet driver support

From: Geert Uytterhoeven <geert@linux-m68k.org>
Date: 2021-07-26 10:55:54
Also in: linux-renesas-soc

Hi Biju,

On Fri, Jul 23, 2021 at 8:28 AM Biju Das [off-list ref] wrote:
quoted
Subject: Re: [PATCH net-next 00/18] Add Gigabit Ethernet driver support

On Thu, Jul 22, 2021 at 11:53:59PM +0300, Sergei Shtylyov wrote:
quoted
On 7/22/21 5:13 PM, Biju Das wrote:
quoted
The DMAC and EMAC blocks of Gigabit Ethernet IP is almost similar to
Ethernet AVB.
quoted
quoted
The Gigabit Etherner IP consists of Ethernet controller (E-MAC),
Internal TCP/IP Offload Engine (TOE) and Dedicated Direct memory access
controller (DMAC).
quoted
quoted
With few changes in driver, we can support Gigabit ethernet driver as
well.
quoted
quoted
This patch series is aims to support the same

RFC->V1
  * Incorporated feedback from Andrew, Sergei, Geert and Prabhakar
  *
https://jpn01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fpa
tchwork.kernel.org%2Fproject%2Flinux-renesas-soc%2Flist%2F%3Fseries%
3D515525&amp;data=04%7C01%7Cbiju.das.jz%40bp.renesas.com%7C6fe3922cc
35d4178cb1d08d94d54bc75%7C53d82571da1947e49cb4625a166a4a2a%7C0%7C0%7
C637625848601442706%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQ
IjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&amp;sdata=bOpIqV1g
lMUXqz9rsX0UK3Oqap2J1cY86TGVOJvzYe4%3D&amp;reserved=0

Biju Das (18):
  dt-bindings: net: renesas,etheravb: Document Gigabit Ethernet IP
  drivers: clk: renesas: rzg2l-cpg: Add support to handle MUX clocks
  drivers: clk: renesas: r9a07g044-cpg: Add ethernet clock sources
  drivers: clk: renesas: r9a07g044-cpg: Add GbEthernet clock/reset

   It's not a good idea to have the patch to the defferent subsystems
lumped all together in a single series...
Agreed.

Are these changes inseparable? If so, you need to be up front on this, and
you need an agreement with the subsystem maintainers how the patches are
going to be merged? Through which tree. And you need Acked-by from the
other tree maintainers.

Ideally you submit multiple patchsets. This assumes all sets will compile
independently.
Agreed. Will split this patch series in 3 patchsets

1) single binding patch

2) Clock patchset

3) ravb driver patchset.
4) dts part.

Part 2 should pass through renesas-clk.
Part 4 should pass through renesas-devel.

Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help