On Tue, Nov 25, 2014 at 5:43 PM, John Fastabend
[off-list ref] wrote:

On 11/25/2014 07:18 AM, Jiri Pirko wrote:

quoted

Tue, Nov 25, 2014 at 04:13:12PM CET, gospo@cumulusnetworks.com wrote:

quoted

On Tue, Nov 25, 2014 at 11:28:33AM +0100, Jiri Pirko wrote:

quoted

Do the work of parsing NDA_VLAN directly in rtnetlink code, pass simple
u16 vid to drivers from there.

Signed-off-by: Jiri Pirko <jiri@resnulli.us>

Structurally this looks fine, just a misspelling noted below.

Acked-by: Andy Gospodarek <redacted>

If your going to spin this, should we return an error from
ndo_dflt_fdb_add() when we have a non-zero vid? The dflt
handler uses the dev_(mc|uc)_add_excl routines which will
not consume vids.

so... was this comment addressed along the discussion? I see in the
code that we don't check
on the _dflt_ handlers nor on the per device ones (ixgbe, i40e, qlgc)
for a valid VID and return
error on that.

If you want to address this with a follow up patch I'm OK
with that. Go ahead and add my ack,