Re: [patch net-next v3 15/17] bridge: add new hwmode swdev
From: Thomas Graf <tgraf@suug.ch>
Date: 2014-11-25 22:56:59
On 11/25/14 at 11:17am, Andy Gospodarek wrote:
quoted hunk ↗ jump to hunk
On Tue, Nov 25, 2014 at 08:03:11AM -0800, Roopa Prabhu wrote:quoted
On 11/25/14, 2:28 AM, Jiri Pirko wrote:quoted
From: Scott Feldman <redacted> Current hwmode settings are "vepa" or "veb". These are for NIC interfaces with basic bridging function offloaded to HW. Add new "swdev" for full switch device offloads.still voting for a generic feature flag like NETIF_F_HW_OFFLOAD for use by bridge/bond/vxlan. I can resubmit my patch that does this.I know it is _early_ to propose this, but I would even suggest this:diff --git a/include/linux/netdev_features.h b/include/linux/netdev_features.h index 8e30685..6cea162 100644 --- a/include/linux/netdev_features.h +++ b/include/linux/netdev_features.h@@ -124,6 +124,7 @@ enum { #define NETIF_F_HW_VLAN_STAG_TX __NETIF_F(HW_VLAN_STAG_TX) #define NETIF_F_HW_L2FW_DOFFLOAD __NETIF_F(HW_L2FW_DOFFLOAD) #define NETIF_F_BUSY_POLL __NETIF_F(BUSY_POLL) +#define NETIF_F_HW_SWITCHING __NETIF_F(HW_SWITCHING) /* Features valid for ethtool to change */ /* = all defined minus driver/device-class-related */
I need more context to understand the intent of this. What does the presence of the flag indicate? Support for swdev API? My understanding is that the API will grow quickly and device will only support a subset of what the API can abstract.