Re: [patch net-next v3 02/17] net: make vid as a parameter for ndo_fdb_add/ndo_fdb_del
From: Jiri Pirko <jiri@resnulli.us>
Date: 2014-11-26 07:54:52
From: Jiri Pirko <jiri@resnulli.us>
Date: 2014-11-26 07:54:52
Tue, Nov 25, 2014 at 11:14:17PM CET, tgraf@suug.ch wrote:
On 11/25/14 at 11:28am, Jiri Pirko wrote:quoted
Do the work of parsing NDA_VLAN directly in rtnetlink code, pass simple u16 vid to drivers from there. Signed-off-by: Jiri Pirko <jiri@resnulli.us>I'm slightly confused ;-) We both argued that parsing Netlink attributes in the drivers is wrong. What happened to the plan of renaming ndo_fdb_ to ndo_neigh_ and introducing a non-Netlink in-kernel API for advanced usage by swdev?
Well the thing is that at the moment, it is not needed to call ndo_fdb_* from inside the kernel. So the whole plan does not have to happen now. Plus I saw the patches (Scott sent me) and I believe that they are unnecessary complex. We can do this later if needed. Now, I would like to stick with what we have so far, keep things simple.