On 11/25/14 at 05:53pm, Jiri Pirko wrote:

Tue, Nov 25, 2014 at 04:58:32PM CET, gospo@cumulusnetworks.com wrote:

quoted

I do not expect that this first set would provide full feedback to
br_make_forwarding, br_make_blocking, etc, to allow spanning tree to
properly deal with the failure (that change is fine to add later), but a
short one-liner indicating that the call to the hardware  failed would e
good.  What about something simple like this:

void br_set_state(struct net_bridge_port *p, unsigned int state)
{
int ret;
p->state = state;
ret = netdev_switch_port_stp_update(p->dev, state);
if (ret && ret != -EOPNOTSUPP)
	br_warn(br, "error setting offload STP state for interface %s\n",
		p->dev->name);
}

That makes sense. Will add this.

Feel free to add:
Acked-by: Thomas Graf <tgraf@suug.ch>