Re: [patch net-next v3 02/17] net: make vid as a parameter for ndo_fdb_add/ndo_fdb_del
From: Thomas Graf <tgraf@suug.ch>
Date: 2014-11-25 23:11:09
On 11/25/14 at 02:39pm, Florian Fainelli wrote:
On 25/11/14 14:14, Thomas Graf wrote:quoted
On 11/25/14 at 11:28am, Jiri Pirko wrote:quoted
Do the work of parsing NDA_VLAN directly in rtnetlink code, pass simple u16 vid to drivers from there. Signed-off-by: Jiri Pirko <jiri@resnulli.us>I'm slightly confused ;-) We both argued that parsing Netlink attributes in the drivers is wrong. What happened to the plan of renaming ndo_fdb_ to ndo_neigh_ and introducing a non-Netlink in-kernel API for advanced usage by swdev?Not sure I follow you here, the commit message says what it says it does, are we looking at the same patch?
I'm referring to the discussion that occured on patch 06/10 of v2: http://www.spinics.net/lists/netdev/msg303637.html http://www.spinics.net/lists/netdev/msg303669.html http://www.spinics.net/lists/netdev/msg303689.html http://www.spinics.net/lists/netdev/msg303706.html I won't hold up this series though. Glad to do the work afterwards.