Re: [patch net-next v3 09/17] bridge: add API to notify bridge driver of learned FBD on offloaded device
From: Jamal Hadi Salim <jhs@mojatatu.com>
Date: 2014-11-25 16:01:27
From: Jamal Hadi Salim <jhs@mojatatu.com>
Date: 2014-11-25 16:01:27
On 11/25/14 05:28, Jiri Pirko wrote:
From: Scott Feldman <redacted> When the swdev device learns a new mac/vlan on a port, it sends some async notification to the driver and the driver installs an FDB in the device. To give a holistic system view, the learned mac/vlan should be reflected in the bridge's FBD table, so the user, using normal iproute2 cmds, can view what is currently learned by the device. This API on the bridge driver gives a way for the swdev driver to install an FBD entry in the bridge FBD table. (And remove one). This is equivalent to the device running these cmds: bridge fdb [add|del] <mac> dev <dev> vid <vlan id> master This patch needs some extra eyeballs for review, in paricular around the locking and contexts. Signed-off-by: Scott Feldman <redacted> Signed-off-by: Jiri Pirko <jiri@resnulli.us>
Like it (thanks for taking the earlier feedback) but I do not see other issue we discussed on policy attribute check that says "I need you to sync this from offload/chip to kernel" so for now only conditional Acked-by: Jamal Hadi Salim [off-list ref] cheers, jamal