RE: [net-next 11/13] igb: Update PTP function names/variables and locations.

-----Original Message-----
From: Richard Cochran [mailto:richardcochran@gmail.com]
Sent: Monday, August 27, 2012 9:44 AM
To: Vick, Matthew
Cc: Keller, Jacob E; Kirsher, Jeffrey T; davem@davemloft.net;
netdev@vger.kernel.org; gospo@redhat.com; sassmann@redhat.com
Subject: Re: [net-next 11/13] igb: Update PTP function names/variables
and locations.

quoted

Unfortunately, the way I've built the series makes it difficult to

put those fixes before the re-factoring. The need for the design change
drove the re-factor to give me the foundation. I'll make a note to
myself to come up with something to apply to stable.

Hm, I didn't see anything here that looks like bug fix. Did I miss
something?  What causes the ifup/ifdown weirdness, anyhow?

(It seems hard to believe that it has something to do with the names or
locations of the various functions.)

Thanks,
Richard

Sorry, I wasn't very clear--I mean the bug fix I have for ifup/ifdown is in the next few patches with the implementation change I'm doing, since the code I have in place to fix it applies only to the new implementation. I'll have to make a separate patch for stable to address it there.

If the ifup/ifdown weirdness happens because we never re-enable timestamping in the hardware following reset and the device goes through a reset during an ifdown/ifup cycle. It's a pretty straightforward fix, so it shouldn't be much effort to spin up something for stable.

Matthew