Re: [net-next 13/13] igb: Store the MAC address in the name in the PTP struct.

On Thu, 2012-08-23 at 12:45 +0200, Richard Cochran wrote:

On Thu, Aug 23, 2012 at 02:56:53AM -0700, Jeff Kirsher wrote:

quoted

From: Matthew Vick <redacted>

Change the name of the adapter in the PTP struct to enable easier
correlation between interface and PTP device.

You want to put the MAC address into the clock name? This is wrong.

Besides, there is no need for this. The ethool method already makes
the correlation crystal clear.

The name field is described as 'A short name to identify the clock'.  It
is not stated whether this is meant to be the name of the clock *device*
or the clock *driver*.  If it's the name of the device then some unique
ID such as the permanent MAC address is required.

The ixgbe driver uses MAC addresses and so did the last submitted
version of PHC support for the sfc driver.

Ben.

-- 
Ben Hutchings, Staff Engineer, Solarflare
Not speaking for my employer; that's the marketing department's job.
They asked us to note that Solarflare product names are trademarked.