RE: [net-next 10/13] igb: Tidy up wrapping for CONFIG_IGB_PTP.

-----Original Message-----
From: Richard Cochran [mailto:richardcochran@gmail.com]
Sent: Thursday, August 23, 2012 4:29 AM
To: Kirsher, Jeffrey T
Cc: davem@davemloft.net; Vick, Matthew; netdev@vger.kernel.org;
gospo@redhat.com; sassmann@redhat.com
Subject: Re: [net-next 10/13] igb: Tidy up wrapping for CONFIG_IGB_PTP.

On Thu, Aug 23, 2012 at 02:56:50AM -0700, Jeff Kirsher wrote:

quoted

From: Matthew Vick <redacted>

For users without CONFIG_IGB_PTP=y, we should not be compiling any

PTP

quoted

code into the driver. Tidy up the wrapping in igb to support this.

I would appreciate being put on Cc: for any PTP stuff.

Also, if you really want to improve the IGB driver, maybe you could
look at what happens to the time stamping when you do an ifdown/ifup on
the card. It seems to screw everything (observed on kernel 3.5).

Thanks,
Richard

Will do going forward. I appreciate the review.

I actually have two patches coming up that bring some further improvements--these first couple patches are foundation for those. In a patch coming up, the ifdown/ifup issue gets resolved.

Cheers,
Matthew