RE: [net-next 12/13] igb: Correct PTP support query from ethtool.

-----Original Message-----
From: netdev-owner@vger.kernel.org [mailto:netdev-
owner@vger.kernel.org] On Behalf Of Richard Cochran
Sent: Thursday, August 23, 2012 4:24 AM
To: Kirsher, Jeffrey T
Cc: davem@davemloft.net; Vick, Matthew; netdev@vger.kernel.org;
gospo@redhat.com; sassmann@redhat.com
Subject: Re: [net-next 12/13] igb: Correct PTP support query from
ethtool.

On Thu, Aug 23, 2012 at 02:56:52AM -0700, Jeff Kirsher wrote:

quoted

From: Matthew Vick <redacted>

Update ethtool_get_ts_info to not report any supported functionality
on
82575 and add support for V2 Sync and V2 Delay packets. In the case
where CONFIG_IGB_PTP is not defined, we should be reporting default
values.

quoted

diff --git a/drivers/net/ethernet/intel/igb/igb_ethtool.c

b/drivers/net/ethernet/intel/igb/igb_ethtool.c

...

quoted

+#endif /* CONFIG_IGB_PTP */
+	default:
+		return ethtool_op_get_ts_info(dev, info);

This is wrong. Using this function advertises that you support SW TX
time stamps, which you do not.

Thanks,
Richard

Thanks--good catch! I thought we supported SW timestamps already. Since we don't, I'll spin a v2 of this patch.

Cheers,
Matthew