Re: [net-next 04/13] e1000e: cleanup checkpatch PREFER_PR_LEVEL warning
From: Joe Perches <joe@perches.com>
Date: 2012-08-23 14:01:46
On Thu, 2012-08-23 at 02:56 -0700, Jeff Kirsher wrote:
From: Bruce Allan <redacted> checkpatch warning: Prefer pr_info(... to printk(KERN_INFO, ...
[]
quoted hunk ↗ jump to hunk
diff --git a/drivers/net/ethernet/intel/e1000e/netdev.c b/drivers/net/ethernet/intel/e1000e/netdev.c
[]
quoted hunk ↗ jump to hunk
@@ -4330,9 +4330,8 @@ static void e1000_print_link_info(struct e1000_adapter *adapter) u32 ctrl = er32(CTRL); /* Link status message must follow this format for user tools */ - printk(KERN_INFO "e1000e: %s NIC Link is Up %d Mbps %s Duplex, Flow Control: %s\n", - adapter->netdev->name, - adapter->link_speed, + pr_info("e1000e: %s NIC Link is Up %d Mbps %s Duplex, Flow Control: %s\n", + adapter->netdev->name, adapter->link_speed, adapter->link_duplex == FULL_DUPLEX ? "Full" : "Half", (ctrl & E1000_CTRL_TFCE) && (ctrl & E1000_CTRL_RFCE) ? "Rx/Tx" : (ctrl & E1000_CTRL_RFCE) ? "Rx" :
I think these conversions are not a good idea. When you have a specific message format that must be followed, use printk. pr_<level> may at some point in the near future use #define pr_fmt(fmt) KBUiLD_MODNAME ": " fmt as a global default equivalent.