From: Pedro Garcia <redacted>
Date: Mon, 28 Jun 2010 01:21:19 +0200

Last version of the patch. Now I think it is OK, of course pending 
Eric's signed-off-by for the accel HW part.

Eric, please review.

If this is too long for a changelog, tell me and I will try to sum it
up:

To me, not commit message is too long, the more the better. :)

+       if ((event == NETDEV_UP) &&
+           (dev->features & NETIF_F_HW_VLAN_FILTER) &&
+           (dev->netdev_ops->ndo_vlan_rx_add_vid)) {

There is no reason to surround this final NULL pointer check with
parenthesis, it just makes reading it confusing.

+       if (vlan_dev)
+               skb->dev = vlan_dev;
+       else
+               if (vlan_id)
+                       goto drop;

Please format this as:

	if (a)
		b;
	else if (c)
		d;

+       if (vlan_dev)
+               skb->dev = vlan_dev;
+       else
+               if (vlan_id)
+                       goto drop;

Same here.