Thread (35 messages) 35 messages, 11 authors, 2010-07-20

Re: [PATCH] vlan_dev: VLAN 0 should be treated as "no vlan tag" (802.1p packet)

From: Ben Hutchings <hidden>
Date: 2010-06-14 17:02:29

On Mon, 2010-06-14 at 18:49 +0200, Pedro Garcia wrote:
On Sun, 13 Jun 2010 22:56:30 +0100, Ben Hutchings
[off-list ref] wrote:
quoted
I have no particular opinion on this change, but you need to read and
follow Documentation/SubmittingPatches.

Ben.
Sorry, first kernel patch, and I did not know about it. I resubmit with
the correct style / format:
[...]

Sorry, no you haven't.

- Networking changes go through David Miller's net-next-2.6 tree so you
need to use that as the baseline, not 2.6.26
- Patches should be applicable with -p1, not -p0 (so if you use diff,
you should run it from one directory level up)
- The patch was word-wrapped

Ben.

-- 
Ben Hutchings, Senior Software Engineer, Solarflare Communications
Not speaking for my employer; that's the marketing department's job.
They asked us to note that Solarflare product names are trademarked.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help