Re: [PATCH] vlan_dev: VLAN 0 should be treated as "no vlan tag" (802.1p packet)
From: Joe Perches <joe@perches.com>
Date: 2010-06-14 19:42:56
On Mon, 2010-06-14 at 19:11 +0200, Patrick McHardy wrote:
Ben Hutchings wrote:quoted
On Mon, 2010-06-14 at 18:49 +0200, Pedro Garcia wrote:quoted
On Sun, 13 Jun 2010 22:56:30 +0100, Ben Hutchings [off-list ref] wrote:quoted
I have no particular opinion on this change, but you need to read and follow Documentation/SubmittingPatches.Sorry, first kernel patch, and I did not know about it. I resubmit with the correct style / format:Sorry, no you haven't. - Networking changes go through David Miller's net-next-2.6 tree so you need to use that as the baseline, not 2.6.26 - Patches should be applicable with -p1, not -p0 (so if you use diff, you should run it from one directory level up) - The patch was word-wrapped
Pedro, you could use git format-patch and git send-email http://linux.yyz.us/git-howto.html http://www.kernel.org/pub/software/scm/git/docs/git-format-patch.html
Additionally: - the pr_debug statements may be useful for debugging, but are a bit excessive for the final version
Patrick, what's wrong with pr_debug? Do you prefer pr_devel?
- Please CC the maintainer (which is me)
scripts/get_maintainer.pl