Ben Hutchings wrote:

On Mon, 2010-06-14 at 18:49 +0200, Pedro Garcia wrote:
  

quoted

On Sun, 13 Jun 2010 22:56:30 +0100, Ben Hutchings
[off-list ref] wrote:
    

quoted

I have no particular opinion on this change, but you need to read and
follow Documentation/SubmittingPatches.

Ben.
      

Sorry, first kernel patch, and I did not know about it. I resubmit with
the correct style / format:
    

[...]

Sorry, no you haven't.

- Networking changes go through David Miller's net-next-2.6 tree so you
need to use that as the baseline, not 2.6.26
- Patches should be applicable with -p1, not -p0 (so if you use diff,
you should run it from one directory level up)
- The patch was word-wrapped

Additionally:

- please use the proper comment style, meaning each line begins
  with a '*'

- the pr_debug statements may be useful for debugging, but are
  a bit excessive for the final version

- + /* 2010-06-13: Pedro Garcia

   We have changelogs for this, simply explaining what the code
   does is enough.

- Please CC the maintainer (which is me)