Re: [PATCH] SMSC LAN911x and LAN921x vendor driver
From: Peter Korsgaard <jacmet@sunsite.dk>
Date: 2008-06-02 18:32:38
Possibly related (same subject, not in this thread)
- 2008-10-21 · [PATCH] SMSC LAN911x and LAN921x vendor driver · Steve Glendinning <hidden>
- 2007-08-07 · Re: [PATCH] SMSC LAN911x and LAN921x vendor driver · Peter Korsgaard <jacmet@sunsite.dk>
- 2007-08-01 · Re: [PATCH] SMSC LAN911x and LAN921x vendor driver · Peter Korsgaard <jacmet@sunsite.dk>
- 2007-07-30 · Re: [PATCH] SMSC LAN911x and LAN921x vendor driver · <hidden>
- 2007-07-29 · Re: [PATCH] SMSC LAN911x and LAN921x vendor driver · Peter Korsgaard <jacmet@sunsite.dk>
quoted
quoted
quoted
quoted
"Bill" == Bill Gatliff [off-list ref] writes:
>>> + /* Initialise tx packet using broadcast destination address */ >>> + for (i = 0; i < 6; i++) >>> + pdata->loopback_tx_pkt[i] = (char)0xFF; >> >> The cast to char is just noise. Bill> Not sure. What about signed vs. unsigned? No, because char can be both signed and unsigned. The driver should rather do a memset(pdate->loopback_tx_pkt, 0xff, ETH_ALEN); -- Bye, Peter Korsgaard